Skip to content

test: automation to cover nil resource selector #955

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
openshift-merge-bot merged 1 commit into from
Dec 4, 2025
Merged

test: automation to cover nil resource selector #955

openshift-merge-bot merged 1 commit into from
Dec 4, 2025

Conversation

@lihongyan1
Copy link
Contributor

@lihongyan1 lihongyan1 commented Dec 3, 2025 •
edited
Loading

The auto covered upstream issue
#932

existing case nilResrouceSelectorPropagatesToPrometheus failed to cover the scenrio

run logs before fixed pr #944 is included in image

 % go test -v -failfast ./test/e2e/... --retain=true -run TestMonitoringStackController/prometheus_with_nil_resource_selector_becomes_ready
=== RUN   TestMonitoringStackController
=== RUN   TestMonitoringStackController/prometheus_with_nil_resource_selector_becomes_ready
    monitoring_stack_controller_test.go:195: statefulset prometheus-nil-selector-ready was never ready with context deadline exceeded
--- FAIL: TestMonitoringStackController (303.09s)
    --- FAIL: TestMonitoringStackController/prometheus_with_nil_resource_selector_becomes_ready (301.32s)
FAIL

@openshift-ci
Copy link

openshift-ci bot commented Dec 3, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: lihongyan1

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved label Dec 3, 2025
simonpasquier
simonpasquier reviewed Dec 4, 2025
View reviewed changes
Copy link
Contributor

@simonpasquier simonpasquier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot added the lgtm label Dec 4, 2025
@openshift-merge-bot openshift-merge-bot bot merged commit 9ac8ef9 into rhobs:main Dec 4, 2025
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@simonpasquier simonpasquier simonpasquier left review comments

@danielmellado danielmellado Awaiting requested review from danielmellado

@jan--f jan--f Awaiting requested review from jan--f

Assignees

@simonpasquier simonpasquier

Labels

approved lgtm

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@lihongyan1 @simonpasquier